fix: fix pending compact retain #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
fix-pending-compact-retain
branch
from
b1f9659 to
ee95976
Compare
driftluo
force-pushed
the
fix-pending-compact-retain
branch
from
ee95976 to
965b06f
Compare
yangby-cryptape
approved these changes
Oct 20, 2021
doitian
approved these changes
Oct 20, 2021
doitian
approved these changes
Oct 20, 2021
|
bors r=doitian,yangby-cryptape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue introduced in #3110
Block number cannot be used as the judgment condition here, but epoch number should be used because any block of the current epoch can be accepted as uncle, and the practice of using block number as the judgment condition will not be able to broadcast and accept some uncle records, resulting in an abnormal uncle rate
Check List
Tests
Release note