fix: session close also should remove feeler dialing flag #3251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
dial command will reject by dialing feeler or session keep online
ckb/network/src/network.rs
Lines 332 to 334 in 5b44843
dialing feeler flag will remove on feeler disconnected
ckb/network/src/protocols/feeler.rs
Lines 47 to 51 in 5b44843
But if the remote side turns off the protocol before local has opened it, the local's dialing feeler flag will not be cleared, also, this node can no longer be dial
why has such a delay on open protocol?
outbound: request open -> wait remote response -> open protocol
inbound: wait request -> send back response and open the protocol
There is a slight difference in the opening time of the two sides
Check List
Tests
Release note