Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix logging feature break #3674

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

fix #3666

resume verification also need logging to debug with some unexpected error

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner October 28, 2022 08:17
@driftluo driftluo requested review from zhangsoledad and removed request for a team October 28, 2022 08:17
script/src/verify.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the fix-logging-feature-break branch from 4a74c3f to c801a8e Compare October 31, 2022 02:55
@driftluo driftluo force-pushed the fix-logging-feature-break branch from c801a8e to a7a1b54 Compare October 31, 2022 03:02
@driftluo
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Oct 31, 2022
3674: fix: fix logging feature break r=driftluo a=driftluo

### What problem does this PR solve?

fix #3666 

resume verification also need logging to debug with some unexpected error

### Check List

Tests

- Unit test
- Integration test


### Release note

```release-note
Title Only: Include only the PR title in the release note.
```



Co-authored-by: driftluo <driftluo@foxmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Build failed:

@driftluo
Copy link
Collaborator Author

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

@bors bors bot merged commit c68dd8e into nervosnetwork:develop Oct 31, 2022
@driftluo driftluo deleted the fix-logging-feature-break branch October 31, 2022 11:15
@doitian doitian mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vm verify logging feature break
2 participants