Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check in-pool chidren for all newly added tx #3713

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: check in-pool chidren for all newly added tx #3713

merged 1 commit into from
Nov 22, 2022

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

Check the in-pool chidren of all newly added transactions and no longer distinguish the entry source of newly added transactions.

What is changed and how it works?

Removed the separate add_entry_from_detached interface, all new add transactions will be checked in-pool chidren

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner November 22, 2022 03:51
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team November 22, 2022 03:51
@zhangsoledad zhangsoledad mentioned this pull request Nov 22, 2022
Merged
@zhangsoledad zhangsoledad changed the title fix: check the in-pool chidren for all newly added tx fix: check in-pool chidren for all newly added tx Nov 22, 2022
@quake
Copy link
Member

quake commented Nov 22, 2022

bors r=quake

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build succeeded:

@bors bors bot merged commit 0877829 into nervosnetwork:develop Nov 22, 2022
bors bot added a commit that referenced this pull request Nov 22, 2022
@bors @zhangsoledad
Merge #3714
63b063d 
3714: [backport] fix: check in-pool chidren for all newly added tx r=quake a=zhangsoledad

backport #3713

Co-authored-by: zhangsoledad <787953403@qq.com>
@doitian doitian mentioned this pull request Nov 22, 2022
Closed
@doitian doitian mentioned this pull request Jan 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangsoledad @quake