-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding RPC: get_transaction_and_witness_proof
& verify_transaction_and_witness_proof
#3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-monad
requested review from
zhangsoledad,
quake and
doitian
and removed request for
a team
November 23, 2022 13:37
quake
reviewed
Nov 24, 2022
code-monad
changed the title
feat: adding RPC:get_witnesses_proof & verify_witnesses_proof
feat: adding RPC: Nov 24, 2022
get_transaction_and_witnesses_proof
& verify_transaction_and_witnesses_proof
code-monad
changed the title
feat: adding RPC:
feat: adding RPC: Nov 24, 2022
get_transaction_and_witnesses_proof
& verify_transaction_and_witnesses_proof
get_transaction_and_witness_proof
& verify_transaction_and_witness_proof
quake
reviewed
Nov 25, 2022
…t_proof_indices into get_tx_indices
quake
approved these changes
Nov 28, 2022
bors r=quake |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #3628
Problem Summary:
What is changed and how it works?
What's Changed:
get_transaction_and_witness_proof
&verify_transaction_and_witness_proof
get_transaction_and_witne_proof
This methods accepts the same params as
get_transaction_proof
, and returns a similar structureTransactionAndWitnessProof
verify_transaction_and_witness_proof
When we called with same valid param of
get_transaction_and_witness_proof
&get_transaction_proof
, use their result as param ofverify_transaction_and_witness_proof
&verify_transaction_proof
, the final result should be the same(the hash of the transaction this proof pointed to)Check List
Tests
Release note