fix: blocktemplate dao potential inconsistent with transactions #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
reviewed
Nov 26, 2022
quake
reviewed
Nov 26, 2022
zhangsoledad
force-pushed
the
zhangsoledad/fix-blocktemplate-dao
branch
from
86ec06c to
751fdc5
Compare
quake
approved these changes
Nov 28, 2022
|
bors r+ |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
3728: [backport] fix: blocktemplate dao potential inconsistent with transactions r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? backport #3727 ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In generating the blocktemplate is probably due to asynchronous reasons, resulting in the calculation of DAO is to filter out some conflicting transactions, but in filling in the blocktemplate transaction field did not use the filtered transactions, so led to potential inconsistency problems.
What is changed and how it works?
Ensure that the transaction used in filling the blocktemplate field is the same as the used in calculating the DAO
Check List
Tests
Release note