Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix 0.107.x] fix: fix identify unregister #3804

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

we introduced peer flags network-wide propagation in #3595

But there is a problem here, only the outbound connection time needs to be refreshed when disconnecting because the global state of connected peers may be deleted first and the flags obtained may be empty, which will reset the correct flags to the default state

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner January 17, 2023 08:19
@driftluo driftluo requested a review from doitian January 17, 2023 08:19
@driftluo driftluo changed the title [bug report]Rc/v0.107.x [bug report]fix: fix identify unregister Jan 17, 2023
@doitian doitian changed the title [bug report]fix: fix identify unregister [hotfix 0.107.x] fix: fix identify unregister Jan 17, 2023
@zhangsoledad
Copy link
Member

bors r+

@bors bors bot merged commit 7f820ec into nervosnetwork:rc/v0.107.x Jan 18, 2023
bors bot added a commit that referenced this pull request Jan 18, 2023
3803: [hotfix 0.107.x] fix: p2p alerts are not filterred in block chain info r=zhangsoledad a=doitian

Rebase #3802 to v0.107.*

Merge #3804 first, which has upgraded tokio for https://rustsec.org/advisories/RUSTSEC-2023-0001

Co-authored-by: ian <ian@nervos.org>
Co-authored-by: zhangsoledad <787953403@qq.com>
@driftluo driftluo deleted the rc/v0.107.x branch January 18, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants