Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: potentially tx-pool panic after detached #3886

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: potentially tx-pool panic after detached #3886

merged 1 commit into from
Mar 15, 2023

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

Fix an issue introduced from https://github.com/nervosnetwork/ckb/pull/3706/files#diff-4e835ff799b925b06ae537862d89faea15095eafdcb95f6e3ee6d74ea4045617R292-R305
that could potentially cause tx-pool panic

What is changed and how it works?

Replace the handling of quick errors with fault tolerance

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad changed the title fix: tx-pool may panic after detached fix: potentially tx-pool panic after detached Mar 15, 2023
@zhangsoledad zhangsoledad marked this pull request as ready for review March 15, 2023 08:02
@zhangsoledad zhangsoledad requested a review from a team as a code owner March 15, 2023 08:02
@zhangsoledad zhangsoledad requested review from quake and removed request for a team March 15, 2023 08:02
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 15, 2023
Merged via the queue into nervosnetwork:develop with commit 0f0ac70 Mar 15, 2023
@doitian doitian mentioned this pull request Apr 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangsoledad @quake