Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the bug of list-hashes subcmd #3892

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

quake
Copy link
Member

@quake quake commented Mar 20, 2023

What problem does this PR solve?

resolve the bug of list-hashes subcmd always listing the bundled data, this bug was introduced by this PR: #3778

Check List

  • Manual test (add detailed scripts or steps below)
./ckb list-hashes
# Generated by: ckb list-hashes

./ckb list-hashes -b
# Generated by: ckb list-hashes -b

Release note

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner March 20, 2023 02:37
@quake quake requested review from doitian and removed request for a team March 20, 2023 02:37
@quake quake enabled auto-merge March 20, 2023 02:47
@quake quake added this pull request to the merge queue Mar 20, 2023
@quake quake merged commit 7674587 into nervosnetwork:develop Mar 20, 2023
@eval-exec
Copy link
Collaborator

eval-exec commented Mar 21, 2023

Do we need to improve the tests here? I'd like to work on this. @quake

function list_hashes { #@test
run _list_hashes
[ "$status" -eq 0 ]
assert_output --regexp "\# Spec: ckb[_]?[a-z]*.*\[ckb[_]?[a-z]*\].*spec_hash = \"0x[0-9a-z]*\""
}
function list_bundle_hashes { #@test
run _list_bundle_hashes
[ "$status" -eq 0 ]
assert_output --regexp "\# Spec: ckb.*\[ckb\].*spec_hash = \"0x[0-9a-z]*\""
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants