Improve tx pool index for different sorting strategies #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
improve-tx-pool-index
branch
2 times, most recently
from
1ae9352 to
6d9b2ea
Compare
chenyukang
force-pushed
the
improve-tx-pool-index
branch
2 times, most recently
from
37c6f61 to
fb1e262
Compare
eval-exec
reviewed
May 8, 2023
| @@ -90,7 +91,7 @@ impl TxEntry { | |||
| } | |||
|
|
|||
| /// Returns a sorted_key | |||
| pub fn as_sorted_key(&self) -> AncestorsScoreSortKey { | |||
| pub fn as_score_key(&self) -> AncestorsScoreSortKey { | |||
There was a problem hiding this comment.
Do we need to change this method's comment?
There was a problem hiding this comment.
I think as_score_key maybe a better name, since we may have other sort keys.
eval-exec
reviewed
May 8, 2023
| self.sorted_index.insert(desc_entry.as_sorted_key()); | ||
| } | ||
| } | ||
| self.update_descendants_index_key(&entry, EntryOp::Remove); |
There was a problem hiding this comment.
How about change EntryOp::Remove to EntryOp::Sub, since its purpose isn't "remove something" but "decrease weight".
eval-exec
approved these changes
May 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #3942
Problem Summary:
What is changed and how it works?
What's Changed:
Related changes
SortedTxMapfor other sorting strategies.Check List
Tests
Side effects
There is a performance penalty for
Add,Removeentries inSortedTxMap:before:
after:
No
Release note