feat: Suspend support in spawn syscalls #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanson
reviewed
Jun 1, 2023
mohanson
approved these changes
Jun 1, 2023
zhangsoledad
approved these changes
Jun 2, 2023
eval-exec
reviewed
Jun 5, 2023
eval-exec
approved these changes
Jun 5, 2023
Co-authored-by: Eval EXEC <execvy@gmail.com>
Co-authored-by: Eval EXEC <execvy@gmail.com>
eval-exec
reviewed
Jun 5, 2023
eval-exec
approved these changes
Jun 6, 2023
XuJiandong
suggested changes
Jun 6, 2023
| callee_peak_memory: u64, | ||
| callee_memory_limit: u64, | ||
| content: Vec<u8>, | ||
| content_length: u64, |
There was a problem hiding this comment.
The inclusion of content_length is unnecessary. This is because once the child script invokes set_content, the content size whether truncated or otherwise, is already known.
There was a problem hiding this comment.
I'm looking at a different angle: this is required to build this syscall used by a child. We don't know that whether a child machine has invoked set_content or not when suspended, so I believe this is required to build the full environment for a child machine.
|
@eval-exec Personally I don't think this PR is an enhancement. To me the previous spawn implementation has a bug when used with the suspend / resume feature. This PR fixes the bug. |
quake
reviewed
Jun 6, 2023
quake
reviewed
Jun 6, 2023
Co-authored-by: Quake Wang <quake.wang@gmail.com>
Co-authored-by: Quake Wang <quake.wang@gmail.com>
Co-authored-by: Quake Wang <quake.wang@gmail.com>
Co-authored-by: Quake Wang <quake.wang@gmail.com>
quake
approved these changes
Jun 6, 2023
Already updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes a bug that when suspend happens when a child machine created by the spawn syscall is running, CKB cannot correctly suspend & resume the VM.
What is changed and how it works?
What's Changed: the bug relating spawn syscall and suspend / resume feature is fixed.
Related changes
owner/repo:Check List
Tests
Side effects
Release note