Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get_consensus compatibility #4034

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: get_consensus compatibility #4034

merged 1 commit into from
Jun 21, 2023

Conversation

zhangsoledad
Copy link
Member

What is changed and how it works?

Revert the formatting changes to get_consensus to make it compatible with the previous version

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner June 21, 2023 10:34
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team June 21, 2023 10:34
eval-exec
eval-exec reviewed Jun 21, 2023
View reviewed changes
miner/src/lib.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec added the b:rpc Break RPC interface label Jun 21, 2023
@zhangsoledad zhangsoledad mentioned this pull request Jun 21, 2023
Merged
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 21, 2023
Merged via the queue into nervosnetwork:develop with commit a0dd224 Jun 21, 2023
@homura homura mentioned this pull request Jul 5, 2023
Closed
5 tasks
@zhangsoledad zhangsoledad deleted the zhangsoledad/compatibility branch July 6, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangsoledad @eval-exec