Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep peer store address unique #4133

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: keep peer store address unique #4133

merged 1 commit into from
Sep 5, 2023

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Sep 1, 2023

What problem does this PR solve?

When the same address enters the peer store, we need to reset the random id and ensure that the address is unique

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner September 1, 2023 03:17
@driftluo driftluo requested review from zhangsoledad and removed request for a team September 1, 2023 03:17
@eval-exec eval-exec self-requested a review September 1, 2023 03:20
@eval-exec eval-exec requested a review from quake September 1, 2023 03:43
@driftluo driftluo force-pushed the fix-peer-store-addr-unique branch 2 times, most recently from a374068 to eb65f4a Compare September 1, 2023 04:52
quake
quake requested changes Sep 4, 2023
View reviewed changes
network/src/peer_store/addr_manager.rs Outdated Show resolved Hide resolved
@quake quake enabled auto-merge September 5, 2023 09:57
@quake quake added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
This was referenced Sep 5, 2023
Merged
Merged
quake added a commit that referenced this pull request Sep 5, 2023
@quake
Merge pull request #4142 from driftluo/rc/v0.111.x
cba96ac 
Backport  #4133
quake added a commit that referenced this pull request Sep 5, 2023
@quake
Merge pull request #4143 from driftluo/rc/v0.110.x
4202354 
Backport  #4133
@zhangsoledad zhangsoledad added this pull request to the merge queue Sep 5, 2023
Merged via the queue into nervosnetwork:develop with commit 0eee83f Sep 5, 2023
34 checks passed
@driftluo driftluo deleted the fix-peer-store-addr-unique branch September 5, 2023 15:04
@doitian doitian mentioned this pull request Sep 14, 2023
Closed
@yangby-cryptape yangby-cryptape mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyr jjyr jjyr left review comments

@quake quake quake approved these changes

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driftluo @quake @jjyr @eval-exec @zhangsoledad