Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CKB's rust-toolchain from 1.67.1 to 1.71.1 #4146

Merged
merged 7 commits into from
Sep 9, 2023
Merged

Upgrade CKB's rust-toolchain from 1.67.1 to 1.71.1 #4146

merged 7 commits into from
Sep 9, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Sep 7, 2023 •
edited
Loading

What problem does this PR solve?

#4138 (comment)

This PR require this: nervosnetwork/ckb-docker-builder#16 .

Related changes

  • Upgrade ckb's rust-toolchain from 1.67.1 to 1.71.1
  • Fix ./devtools/doc/rpc.py

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@doitian
Copy link
Member

doitian commented Sep 7, 2023

New builder images have been published in https://github.com/nervosnetwork/ckb-docker-builder

eval-exec and others added 4 commits September 8, 2023 19:12
@eval-exec @zhangsoledad
Fix rpc.py
f48ada4 
Signed-off-by: Eval EXEC <execvy@gmail.com>
Co-authored-by: zhangsoledad <787953403@qq.com>
@eval-exec
Fix clippy::derivable_impls for enum Default
21a0368
@eval-exec
Fix clippy::useless_conversion
7ba2395
@eval-exec
Fix clippy::unused-mut
8188336
@eval-exec eval-exec marked this pull request as ready for review September 8, 2023 12:25
@eval-exec eval-exec requested a review from a team as a code owner September 8, 2023 12:25
@eval-exec eval-exec added the s:waiting-on-reviewers Status: Waiting for Review label Sep 8, 2023
@eval-exec eval-exec marked this pull request as draft September 8, 2023 12:27
@eval-exec eval-exec marked this pull request as ready for review September 8, 2023 13:28
@doitian doitian added this pull request to the merge queue Sep 9, 2023
Merged via the queue into nervosnetwork:develop with commit 6aeb1ee Sep 9, 2023
34 checks passed
@doitian doitian mentioned this pull request Sep 11, 2023
Closed
@doitian
Copy link
Member

doitian commented Sep 11, 2023

@eval-exec could you help to upgrade the rust version in https://github.com/nervosnetwork/ckb-sdk-rust as well?

@eval-exec
Copy link
Collaborator Author

@eval-exec could you help to upgrade the rust version in https://github.com/nervosnetwork/ckb-sdk-rust as well?

Sure.

@doitian doitian mentioned this pull request Oct 9, 2023
Closed
@zhangsoledad zhangsoledad mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake Awaiting requested review from quake

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
s:waiting-on-reviewers Status: Waiting for Review
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @doitian