Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless --cfg disable_faketime from RUSTFLAGS #4160

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Remove useless --cfg disable_faketime from RUSTFLAGS #4160

merged 4 commits into from
Sep 17, 2023

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

We have removed the faketime crate from #3777. As a result, the #[cfg(not(disable_faketime))] is now meaningless and can be removed.

What's Changed:

Related changes

  • Remove useless --cfg disable_faketime from RUSTFLAGS

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • NOne

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner September 17, 2023 02:36
@eval-exec eval-exec requested review from doitian and zhangsoledad and removed request for a team September 17, 2023 02:36
@quake quake added this pull request to the merge queue Sep 17, 2023
Merged via the queue into nervosnetwork:develop with commit 5ba499a Sep 17, 2023
34 checks passed
@doitian doitian mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @quake