New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New script verify with ckb-vm pause #4291

Merged

chenyukang merged 318 commits into nervosnetwork:develop from chenyukang:yukang-new-verify

Aug 12, 2024

Collaborator

chenyukang commented Jan 4, 2024 •

edited

Loading

What problem does this PR solve?

New script verify flow based on ckb-vm pause

What is changed and how it works?

Use a job queue for pending transactions waiting for verifying
Multiple workers trigger the verification process by picking task from queue
Verification is changed to async style
Use channel to resume/suspend vm
No snapshot from VM machines
No Suspend state from cache
All transactions from remote peer will be added into queue

What's Changed:

Related changes

PR to update owner/repo:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code ci-runs-only: [ quick_checks,linters ]

Side effects

Performance regression
Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

chenyukang requested a review from a team as a code owner

January 4, 2024 10:15

chenyukang requested review from doitian and removed request for a team

January 4, 2024 10:15

chenyukang marked this pull request as draft

January 4, 2024 10:17

chenyukang force-pushed the yukang-new-verify branch 10 times, most recently from 6f64322 to 60a65ba Compare

January 17, 2024 07:36

chenyukang marked this pull request as ready for review

January 17, 2024 16:20

chenyukang force-pushed the yukang-new-verify branch 2 times, most recently from 9e339fa to 9c66560 Compare

January 17, 2024 17:03

chenyukang changed the title ~~[WIP] New script verify with ckb-vm pause~~ New script verify with ckb-vm pause

chenyukang force-pushed the yukang-new-verify branch 2 times, most recently from 3fa3376 to b0f1d76 Compare

January 18, 2024 06:49

eval-exec reviewed

View reviewed changes

verification/src/transaction_verifier.rs Outdated Show resolved Hide resolved

eval-exec added t:enhancement m:vm labels

eval-exec reviewed

View reviewed changes

verification/src/transaction_verifier.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/component/verify_queue.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/component/verify_queue.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/component/verify_queue.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/component/verify_queue.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/process.rs Outdated Show resolved Hide resolved

eval-exec reviewed

View reviewed changes

tx-pool/src/process.rs Outdated Show resolved Hide resolved

eval-exec requested review from zhangsoledad, driftluo and yangby-cryptape

August 2, 2024 12:06


          make clippy happy

46ba28a

chenyukang dismissed eval-exec’s stale review via

46ba28a

August 2, 2024 13:12

eval-exec previously approved these changes

View reviewed changes

zhangsoledad previously approved these changes

View reviewed changes

zhangsoledad added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

zhangsoledad added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Collaborator

eval-exec commented Aug 5, 2024

@zhangsoledad We need to merge #4563 firstly

Collaborator

eval-exec commented Aug 5, 2024

Although the CI issues haven't been completely resolved, they no longer affect PR merges.
I also suggest squashing multiple commits into a few.

chenyukang added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

chenyukang added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks


          Merge branch 'develop' into yukang-new-verify

964817b

chenyukang enabled auto-merge

August 12, 2024 09:55

chenyukang dismissed stale reviews from eval-exec and zhangsoledad via

b140158

August 12, 2024 10:06


          fix rpc test

454c1c5

chenyukang force-pushed the yukang-new-verify branch from b140158 to 454c1c5 Compare

August 12, 2024 10:18

eval-exec approved these changes

View reviewed changes

chenyukang added this pull request to the merge queue

Merged via the queue into nervosnetwork:develop with commit 9e924c9

32 checks passed

doitian mentioned this pull request

Release CKB v0.118.0 #4598

Closed

3 tasks

This was referenced Aug 24, 2024

chore(RPC): add RPC to clear verify queue #4609

Merged

Recover possible transaction in conflicted cache when RBF #4561

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eval-exec eval-exec approved these changes

zhangsoledad zhangsoledad left review comments

quake Awaiting requested review from quake

doitian Awaiting requested review from doitian

driftluo Awaiting requested review from driftluo

yangby-cryptape Awaiting requested review from yangby-cryptape

Labels

m:vm t:enhancement t:epic u:ckb2023