Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Don't account for cell dep for MAX_ANCESTORS_COUNT #4330

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

We met a scenario that a cell dep may have many transactions as descendants, and we can not submit a new transaction to consume the dep cell.

Problem Summary:

What is changed and how it works?

cell dep should be handled specially when calculating the entry's ancestors_count.
In this PR, we add a direct_ancestors_count to store the directed parent-child relationship between transactions.

This is a short-term solution.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner January 29, 2024 08:19
@chenyukang chenyukang requested a review from quake January 29, 2024 08:19
@quake quake merged commit e05270a into nervosnetwork:rc/v0.113.x Jan 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants