Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexerService::try_loop_sync should not run if ckb has received stop signal #4351

Merged
merged 5 commits into from
Feb 19, 2024
Merged

IndexerService::try_loop_sync should not run if ckb has received stop signal #4351

merged 5 commits into from
Feb 19, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Feb 18, 2024 •
edited
Loading

What problem does this PR solve?

Related changes

  • try_loop_sync should not run if ckb has received stop signal.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested review from EthanYuan and quake February 18, 2024 02:17
@eval-exec eval-exec force-pushed the exec/indexer-try_loop_sync-exit branch 2 times, most recently from 34d358d to 0a91063 Compare February 18, 2024 02:37
@eval-exec
IndexerService::try_loop_sync should not run if ckb has received stop…
2f6b67d 
… signal

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/indexer-try_loop_sync-exit branch from 0a91063 to 2f6b67d Compare February 18, 2024 02:38
@eval-exec eval-exec changed the title IndexerService::try_loop_sync should exit after ckb received stop signal IndexerService::try_loop_sync should not run if ckb has received stop signal Feb 18, 2024
@eval-exec eval-exec marked this pull request as ready for review February 18, 2024 02:40
@eval-exec eval-exec requested a review from a team as a code owner February 18, 2024 02:40
@eval-exec
IndexerService::try_loop_sync should break if has_received_stop_signa…
b36241d 
…l is true

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/indexer-try_loop_sync-exit branch from d882133 to b36241d Compare February 18, 2024 03:33
@quake quake added this pull request to the merge queue Feb 19, 2024
Merged via the queue into nervosnetwork:develop with commit 4cd7845 Feb 19, 2024
33 checks passed
@eval-exec eval-exec mentioned this pull request Feb 19, 2024
Merged
doitian added a commit that referenced this pull request Feb 19, 2024
@doitian
Merge pull request #4354 from eval-exec/exec/backport/4351
76f4b1a 
Backport #4351 `IndexerService::try_loop_sync` should not run if ckb has received stop signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanYuan EthanYuan EthanYuan approved these changes

@quake quake quake approved these changes

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @EthanYuan