New spawn with scheduler #4380
Merged
New spawn with scheduler #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ckb-c-stdlib with new spawn syscalls. Update db feature
* format code * Use libc from ckb-c-stdlib Add test case: check_spawn_strcat
* Add more test cases * Add more test cases
* Rewrite current_cycles * Rewrite process_id * Rewrite pipe * Rewrite wait * Rewrite read/write * Rewrite inherited_fd * Rewrite close
* Add test cases * Add more test cases * typo * Fix spawn with inherited fd without ownership * Add other end close case Fix build.rs * Wait child process and exit
* Support spawn program in witnesses * Add cycles charge for spawn * Generic type * Staged * Rewrite spawn
* Add max_vms_count * Typo
chenyukang
reviewed
Mar 13, 2024
chenyukang
reviewed
Mar 13, 2024
chenyukang
merged commit a91689c
into
nervosnetwork:new-verify-with-sched
26 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we refactored the implementation of spawn. The refactored syscall API is defined as follows: https://github.com/XuJiandong/ckb-c-stdlib/blob/syscall-spawn/ckb_syscall_apis.h#L54-L68.
Review Introduction: #4380 (comment)
Documentation: nervosnetwork/rfcs#436