Set ChainService process_block channel size to zero #4418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
On the develop branch, the
ChainService
'sprocess_block
channel has a capacity ofDEFAULT_CHANNEL_SIZE
(32), but it does not provide any benefit forckb-sync
orckb-chain
:ckb/chain/src/chain.rs
Line 225 in 149b5c5
In a scenario where
ckb-sync
sends a block toChainService
throughChainController::process_block
, and at the same time,ChainService
receives aCtrl-C
exit signal.Then
ChainService
'sprocess_block_sender
have oneProcessBlockRequest
in its buffer:ckb/chain/src/chain.rs
Line 41 in 149b5c5
When
self.process_block_sender
andself.stop_receiver
are ready at the same time,ChainService
'sselect!
may choose to executeself.stop_receiver
:ckb/chain/src/chain.rs
Lines 237 to 272 in 149b5c5
then the
process_block_receiver
will be dropped.However, the
process_block_sender
is held by theSynchronizer
'sChainController
, and there is oneProcessBlockRequest
inprocess_block_sender
's buffer, causing theChainController::internal_block_process
to block indefinitely.In that case,
Synchronizer::received
will block indefinitely at this point:ckb/sync/src/synchronizer/mod.rs
Line 784 in 149b5c5
What is changed and how it works?
Related changes
ChainService
's process_block channel capacity size to 0.Check List
Tests
Side effects
Release note