Use standalone runtime for RPC service #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
rpc-new-runtime
branch
2 times, most recently
from
3e0ec0f to
033768c
Compare
chenyukang
changed the title
chenyukang
force-pushed
the
rpc-new-runtime
branch
from
033768c to
e9093b8
Compare
quake
previously approved these changes
May 21, 2024
eval-exec
approved these changes
Jun 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zhangsoledad
approved these changes
Jun 28, 2024
eval-exec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, we have some RPC API from indexer such as
get_cells,get_transactions,get_cells_capacitywhich may cost a lot of computing resources, it may occupy all the tokio tasks, andckbcan not process blocks in extreme scenarios.What is changed and how it works?
RPC will run in a standalone tokio runtime, so that we can process block even in extreme scenario.
Check List
Tests
Side effects
Release note