Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add clippy::redundant_clone #4495

Merged
merged 1 commit into from
Jun 26, 2024
Merged

chore: add clippy::redundant_clone #4495

merged 1 commit into from
Jun 26, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

When I review a performance issue, I found there are some necessary clones.
clippy::redundant_clone may remove them from the code.

What is changed and how it works?

add clippy::redundant_clone.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner June 25, 2024 14:07
@chenyukang chenyukang requested review from quake and removed request for a team June 25, 2024 14:07
@eval-exec eval-exec added the t:ci Type: CI label Jun 25, 2024
@quake quake added this pull request to the merge queue Jun 26, 2024
Merged via the queue into nervosnetwork:develop with commit 36413b0 Jun 26, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake quake approved these changes

Assignees
No one assigned
Labels
t:ci Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @quake @eval-exec