Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early return process_fetch_cmd if ckb received exit signal #4527

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Early return process_fetch_cmd if ckb received exit signal #4527

merged 1 commit into from
Jul 18, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jul 17, 2024 •
edited
Loading

What is changed and how it works?

Related changes

  • Early return BlockFetchCMD::process_fetch_cmd if ckb has received exit signal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner July 17, 2024 11:12
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team July 17, 2024 11:13
@eval-exec eval-exec force-pushed the exec/early-return-process_fetch_cmd branch from 7ae1bbf to 79c565d Compare July 17, 2024 11:14
@eval-exec eval-exec force-pushed the exec/early-return-process_fetch_cmd branch from 79c565d to 7f14914 Compare July 17, 2024 11:15
@quake quake added this pull request to the merge queue Jul 18, 2024
Merged via the queue into nervosnetwork:develop with commit 320f8fc Jul 18, 2024
32 checks passed
@eval-exec eval-exec mentioned this pull request Jul 19, 2024
Merged
doitian added a commit that referenced this pull request Jul 22, 2024
@doitian
Merge pull request #4531 from eval-exec/exec/backport/4527
1474782 
Backport #4527 Early return process_fetch_cmd if ckb received exit signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @doitian @quake