Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix atomic ordering in multi-thread #4623

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: fix atomic ordering in multi-thread #4623

merged 1 commit into from
Aug 30, 2024

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

In multi-threaded state, atomic should use Acquire/Release at least

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner August 28, 2024 06:43
@driftluo driftluo requested review from doitian and removed request for a team August 28, 2024 06:43
eval-exec
eval-exec previously approved these changes Aug 28, 2024
View reviewed changes
@eval-exec eval-exec requested a review from chenyukang August 29, 2024 03:06
@eval-exec
Copy link
Collaborator

please rebase onto develop.

@eval-exec eval-exec force-pushed the fix-atomic-ordering branch from 6590022 to fab3486 Compare August 29, 2024 03:21
chenyukang
chenyukang previously approved these changes Aug 29, 2024
View reviewed changes
@eval-exec eval-exec enabled auto-merge August 29, 2024 03:37
@eval-exec eval-exec added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@driftluo driftluo force-pushed the fix-atomic-ordering branch 2 times, most recently from 1a31768 to 922816b Compare August 29, 2024 06:32
@eval-exec eval-exec enabled auto-merge August 29, 2024 06:33
@driftluo driftluo dismissed stale reviews from eval-exec and chenyukang via 258676a August 29, 2024 06:59
@driftluo driftluo force-pushed the fix-atomic-ordering branch from 922816b to 258676a Compare August 29, 2024 06:59
@eval-exec eval-exec added this pull request to the merge queue Aug 30, 2024
@eval-exec eval-exec mentioned this pull request Aug 30, 2024
Closed
@driftluo driftluo force-pushed the fix-atomic-ordering branch from 258676a to b414a64 Compare August 30, 2024 01:52
Merged via the queue into nervosnetwork:develop with commit 2fb17ab Aug 30, 2024
30 of 31 checks passed
@driftluo driftluo deleted the fix-atomic-ordering branch August 30, 2024 02:37
@doitian doitian mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@chenyukang chenyukang chenyukang left review comments

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @eval-exec @chenyukang