Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate default.db-options file if it not exist #4700

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Generate default.db-options file if it not exist #4700

merged 1 commit into from
Nov 14, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 28, 2024 •
edited
Loading

What problem does this PR solve?

close #4671

Related changes

  • Generate default.db-options file if it not exist

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/generate-default-db-options branch from 03ce485 to d06619f Compare October 28, 2024 10:10
@eval-exec eval-exec changed the title Generate default.db-options file if it not exist, #4671 Generate default.db-options file if it not exist Oct 28, 2024
@eval-exec eval-exec force-pushed the exec/generate-default-db-options branch 2 times, most recently from 387b994 to 05da01d Compare October 28, 2024 10:25
@eval-exec eval-exec force-pushed the exec/generate-default-db-options branch from 05da01d to 408b378 Compare November 13, 2024 02:06
@eval-exec eval-exec marked this pull request as ready for review November 13, 2024 02:06
@eval-exec eval-exec requested a review from a team as a code owner November 13, 2024 02:06
@eval-exec eval-exec requested review from doitian and removed request for a team November 13, 2024 02:06
@eval-exec eval-exec force-pushed the exec/generate-default-db-options branch from 408b378 to ece18e5 Compare November 13, 2024 02:07
@eval-exec eval-exec changed the title Generate default.db-options file if it not exist Generate default.db-options file if it not exist Nov 13, 2024
@eval-exec
Generate default.db-options file if it not exist, nervosnetwork#4671
d750782 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/generate-default-db-options branch from ece18e5 to d750782 Compare November 14, 2024 03:49
@doitian doitian added this pull request to the merge queue Nov 14, 2024
Merged via the queue into nervosnetwork:develop with commit c5ef755 Nov 14, 2024
33 checks passed
@doitian doitian mentioned this pull request Nov 18, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@doitian doitian doitian approved these changes

@quake quake Awaiting requested review from quake

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure ckb run Automatically Creates default.db-options if Missing in data_dir
3 participants
@eval-exec @doitian @driftluo