Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentifyMessage::decode allow failure on Unsupported MultiAddr #4759

Closed
wants to merge 1 commit into from
Closed

IdentifyMessage::decode allow failure on Unsupported MultiAddr #4759

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Dec 25, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

When a remote peer's IdentifyMessage contains 1 multiaddr which cannot parse successfully, should ignore that one, instead return an empty public_addrs.

What's Changed:

Related changes

  • let IdentifyMessage::decode allow parse failure on Unsupported MultiAddr

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec marked this pull request as ready for review December 30, 2024 04:06
@eval-exec eval-exec requested a review from a team as a code owner December 30, 2024 04:06
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team December 30, 2024 04:06
@eval-exec eval-exec force-pushed the exec/IdentifyMessage-decode-allow-failure branch from eec0388 to 3395bfa Compare December 30, 2024 04:06
@eval-exec eval-exec requested review from quake and driftluo December 30, 2024 04:07
@eval-exec
Copy link
Collaborator Author

eval-exec commented Dec 30, 2024 •
edited
Loading

This change should be added in #4733

@eval-exec eval-exec closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@quake quake Awaiting requested review from quake

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
m:network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eval-exec