Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sync): Fix get ancestor performance issue #970

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

TheWaWaR
Copy link
Contributor

@TheWaWaR TheWaWaR commented Jun 8, 2019

  • Use skip list to search ancestor of a header
  • Adjust block fetch interval IBD/not-IBD
  • Add test for skip list

NOTE: The implementation and test is almost copy from bitcoin.

@TheWaWaR TheWaWaR requested a review from a team June 8, 2019 06:05
@nervos-bot
Copy link

nervos-bot bot commented Jun 8, 2019

@quake is assigned as the chief reviewer

sync/src/types.rs Show resolved Hide resolved
sync/src/types.rs Show resolved Hide resolved
@TheWaWaR TheWaWaR changed the title perf(sync): Fix get ancestor perf issue perf(sync): Fix get ancestor performance issue Jun 9, 2019
@doitian
Copy link
Member

doitian commented Jun 11, 2019

It's an important performance improvement, could you backport this PR to rc/v0.14.0? I think we need this PR in the next release.

@TheWaWaR
Copy link
Contributor Author

It's an important performance improvement, could you backport this PR to rc/v0.14.0? I think we need this PR in the next release.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants