Validate native token transfer raw tx and signature #788

magicalne · 2022-08-24T06:38:31Z

godwokenrises/godwoken-polyjuice#173

check to_id == polyjuice_creator_id
update verify_tx for native token transfer

crates/utils/src/polyjuice_parser.rs

crates/generator/src/generator.rs

crates/generator/src/verification/transaction.rs

gw-bot · 2022-08-29T09:32:48Z

Running integration test

Workflow Run Id: 2947452850

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 6e6d0b2
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 4000c78
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-29T11:23:17Z

Running integration test

Workflow Run Id: 2948110177

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 0f26eca
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 4000c78
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-29T13:37:35Z

Running integration test

Workflow Run Id: 2948956547

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 55eae98
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 4000c78
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-29T14:54:53Z

Running integration test

Workflow Run Id: 2949507200

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: c7480ef
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

jjyr · 2022-08-30T03:05:42Z

/itest

gw-bot · 2022-08-30T03:06:08Z

Running integration test

Workflow Run Id: 2953256642

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: c7480ef
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

…ansfer

…ove polyjuice_creator_id into structs

gw-bot · 2022-08-30T05:09:33Z

Running integration test

Workflow Run Id: 2953676985

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 1a95499
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-30T09:31:06Z

Running integration test

Workflow Run Id: 2955122287

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 3c09fb4
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-30T10:29:49Z

Running integration test

Workflow Run Id: 2955495326

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 354eb81
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 8607b58

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

zeroqn · 2022-08-31T03:05:40Z

crates/generator/src/verification/transaction.rs

+            if p.is_native_transfer() {
+                // Verify to_id is CREATOR_ID
+                let to_id = raw_tx.to_id().unpack();
+                if Some(to_id) != self.polyjuice_creator_id && self.polyjuice_creator_id.is_some() {


if polyjuice_creator_id is None, this check will pass? Caller must ensure polyjuice_creator_id is Some?
Maybe pass beckend_manage and call utils::get_polyjuice_creator_id if polyjuice_creator_id is None?

crates/mem-pool/src/pool.rs

gw-bot · 2022-08-31T07:31:06Z

Running integration test

Workflow Run Id: 2962045709

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: cd170ee
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 2b99e2e

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-31T08:21:23Z

Running integration test

Workflow Run Id: 2962338898

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 71dbf3e
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 2b99e2e

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

gw-bot · 2022-08-31T08:43:58Z

Running integration test

Workflow Run Id: 2962477193

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 62d6e05
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 2b99e2e

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

gw-bot · 2022-08-31T09:32:52Z

Running integration test

Workflow Run Id: 2962789508

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: a25b8b4
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 2b99e2e

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

gw-bot · 2022-08-31T10:59:04Z

Running integration test

Workflow Run Id: 2963297789

Components:

prebuilds: 1.5-rc-202208230727,1.5-rc
godwoken: 922970a
scripts: prebuilds 430247e
polyjuice: prebuilds 4d068a0
kicker: 6b1d848
tests: 2b99e2e

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

This comment was marked as outdated.

Sign in to view

magicalne requested review from jjyr, zeroqn and keroro520 August 24, 2022 07:11

Flouse assigned magicalne Aug 24, 2022

Flouse changed the title ~~Validate native token transfer raw tx and signature.~~ Validate native token transfer raw tx and signature Aug 24, 2022

Flouse added the enhancement New feature or request label Aug 24, 2022

keroro520 previously approved these changes Aug 25, 2022

View reviewed changes

crates/utils/src/polyjuice_parser.rs Show resolved Hide resolved

zeroqn previously approved these changes Aug 26, 2022

View reviewed changes

Flouse mentioned this pull request Aug 26, 2022

Support native transfer godwokenrises/godwoken-web3#505

Merged

jjyr requested changes Aug 29, 2022

View reviewed changes

crates/generator/src/generator.rs Show resolved Hide resolved

crates/generator/src/verification/transaction.rs Outdated Show resolved Hide resolved

crates/generator/src/verification/transaction.rs Outdated Show resolved Hide resolved

magicalne dismissed stale reviews from zeroqn and keroro520 via 6e6d0b2 August 29, 2022 09:32

magicalne requested review from jjyr and keroro520 August 29, 2022 21:38

jjyr previously approved these changes Aug 30, 2022

View reviewed changes

magicalne added 5 commits August 30, 2022 13:08

feat: check to_id transfer and validate signature for native token tr…

a6a130c

…ansfer

feat: add test of verifying signature of native token transfer

1988897

fix: copy from slice

e2ae180

refactor: extract method of get_polyjuice_creator_id into utils and m…

2a6652a

…ove polyjuice_creator_id into structs

fix(tests): fix tests by mocking polyjuice creator id

1a95499

magicalne dismissed jjyr’s stale review via 1a95499 August 30, 2022 05:09

fix: cannot find polyjuice creator id before it is created

354eb81

magicalne requested a review from jjyr August 30, 2022 11:47

zeroqn reviewed Aug 31, 2022

View reviewed changes

jjyr requested changes Aug 31, 2022

View reviewed changes

crates/mem-pool/src/pool.rs Outdated Show resolved Hide resolved

fix: check polyjuice creator id is none before

62d6e05

refactor: cache polyjuice creator id in generator

a25b8b4

magicalne requested review from zeroqn and jjyr August 31, 2022 10:49

chore: remove useless code

922970a

jjyr approved these changes Aug 31, 2022

View reviewed changes

keroro520 approved these changes Sep 1, 2022

View reviewed changes

jjyr merged commit 21eda62 into godwokenrises:develop Sep 1, 2022

Flouse mentioned this pull request Sep 26, 2022

FAQ update godwokenrises/godwoken-doc#81

Merged

Flouse mentioned this pull request Apr 3, 2023

Weaken the guidance of pCKB contract godwokenrises/godwoken-doc#154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate native token transfer raw tx and signature #788

Validate native token transfer raw tx and signature #788

magicalne commented Aug 24, 2022 •

edited by jjyr

Loading

This comment was marked as outdated.

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

jjyr commented Aug 30, 2022

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

zeroqn Aug 31, 2022

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

Validate native token transfer raw tx and signature #788

Validate native token transfer raw tx and signature #788

Conversation

magicalne commented Aug 24, 2022 • edited by jjyr Loading

This comment was marked as outdated.

gw-bot bot commented Aug 29, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 29, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 29, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 29, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

jjyr commented Aug 30, 2022

gw-bot bot commented Aug 30, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 30, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 30, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 30, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

zeroqn Aug 31, 2022

Choose a reason for hiding this comment

gw-bot bot commented Aug 31, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 31, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 31, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 31, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Aug 31, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

magicalne commented Aug 24, 2022 •

edited by jjyr

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 29, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 30, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading

gw-bot bot commented Aug 31, 2022 •

edited

Loading