Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

fix(deps): install cross-fetch & jsbi for lumos peerDeps #104

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix(deps): install cross-fetch & jsbi for lumos peerDeps #104

merged 1 commit into from
Mar 25, 2022

Conversation

RetricSu
Copy link
Collaborator

since lumos/toolkit use peerDependencies for cross-fetch/jsbi, the version 0.1.4 of provider might throw the following error:

./node_modules/@ckb-lumos/toolkit/lib/rpc.js
Module not found: Can't resolve 'cross-fetch' in '/Users/retric/Desktop/release-workspace/polyjuice-provider-example/node_modules/@ckb-lumos/toolkit/lib'

this PR fix this by:

  • install cross-fetch/jsbi in godwoken submodules, other submodules all depend on godwoken, so that should be enough
  • remove the un-needed cross-fetch in devDependencies in all submodules.

@RetricSu RetricSu requested a review from classicalliu as a code owner March 25, 2022 09:34
@RetricSu RetricSu linked an issue Mar 25, 2022 that may be closed by this pull request
v0.1.4 Module not found: Can't resolve 'cross-fetch' #105
Closed
@RetricSu RetricSu merged commit 2b97575 into main Mar 25, 2022
@RetricSu RetricSu deleted the fix-peer-deps branch March 25, 2022 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@classicalliu classicalliu classicalliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.1.4 Module not found: Can't resolve 'cross-fetch'
2 participants
@RetricSu @classicalliu