Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

fix: make godwoken package strict tsconfig compatible #65

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

e00dan
Copy link
Contributor

@e00dan e00dan commented Nov 16, 2021

Changes:

  1. Move typescript package to global package.json and remove it from individual package.json to avoid repetition
  2. Fix @polyjuice-provider/godwoken compatibility with TypeScript 4.4 when "strict" in tsconfig.json is set to true
  3. Use ES2019 for @polyjuice-provider/godwoken compatibility with Create React App

Fixed problem:
image

Literature:

  1. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#defaulting-to-the-unknown-type-in-catch-variables---useunknownincatchvariables
  2. https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables (default to true when strict true)

Please review @RetricSu

@RetricSu RetricSu merged commit dcc024b into nervosnetwork:main Nov 18, 2021
@e00dan e00dan deleted the fix/godwoken-ts-4 branch November 18, 2021 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants