fix(0044): a stupid design mistake in light client protocol #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
added a commit
to yangby-cryptape/ckb
that referenced
this pull request
Dec 8, 2022
yangby-cryptape
added a commit
to yangby-cryptape/ckb
that referenced
this pull request
Dec 8, 2022
quake
approved these changes
Dec 8, 2022
yangby-cryptape
added a commit
to yangby-cryptape/ckb
that referenced
this pull request
Dec 8, 2022
yangby-cryptape
added a commit
to yangby-cryptape/ckb
that referenced
this pull request
Dec 8, 2022
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Dec 9, 2022
3745: [backport] fix(light-client): according to the rfc change (nervosnetwork/rfcs#397) r=zhangsoledad a=yangby-cryptape ### What problem does this PR solve? Backport #3744. ### Check List Tests - Unit test - Integration test - Manual test (add detailed scripts or steps below) - No code ci-runs-only: [ quick_checks,linters ] ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` 3747: [backport] fix: get_fee_rate_statics compatibility r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? backport #3746 ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com> Co-authored-by: zhangsoledad <787953403@qq.com>
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Dec 9, 2022
3744: fix(light-client): according to the rfc change (nervosnetwork/rfcs#397) r=zhangsoledad a=yangby-cryptape ### What problem does this PR solve? Fix a stupid design mistake according to the rfc change (nervosnetwork/rfcs#397). ### Check List Tests - Unit test - Integration test - Manual test (add detailed scripts or steps below) - No code ci-runs-only: [ quick_checks,linters ] ### Release note ```release-note None: Exclude this PR from the release note. ``` 3746: fix: get_fee_rate_statics compatibility r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? Due to the inertia of the previous fee_rate usage, change the unit returned by get_fee_rate_statics to shannons per kilo-weight ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com> Co-authored-by: zhangsoledad <787953403@qq.com>
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Dec 9, 2022
3745: [backport] fix(light-client): according to the rfc change (nervosnetwork/rfcs#397) r=zhangsoledad a=yangby-cryptape ### What problem does this PR solve? Backport #3744. ### Check List Tests - Unit test - Integration test - Manual test (add detailed scripts or steps below) - No code ci-runs-only: [ quick_checks,linters ] ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com>
zhangsoledad
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needless to explain too much; it's a mistake, obviously.
Docs and codes related to it are written in February; and every time when I updated the docs and codes, I didn't notice that mistake, until last night.