Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to v8.1.1 #45

Merged
merged 2 commits into from
May 15, 2023

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented May 11, 2023

Fix build with gcc 13 by including <cstdint>
facebook/rocksdb@88edfbf

@zhangsoledad zhangsoledad marked this pull request as ready for review May 15, 2023 02:51
@yangby-cryptape
Copy link
Collaborator

There is a test that not included in CI was broken:

test:
cargo build
rm -rf tmp-test-memory-leak
gcc -g -I rocksdb/include/ -I . \
-L $$(find . -name "librocksdb.a" -exec dirname {} \; | head -1) \
-o tmp-test-memory-leak \
tests/memory/rocksdb_options_load_from_file.c \
-lrocksdb -lpthread -ldl -lm -lstdc++ \
&& valgrind --tool=memcheck --leak-check=full ./tmp-test-memory-leak \
&& rm tmp-test-memory-leak

This test was used to check if there is any memory leak. (Ref: #18 (comment))

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/811 branch 3 times, most recently from 5fc5221 to f6aaa56 Compare May 15, 2023 07:21
@zhangsoledad zhangsoledad merged commit 7065504 into nervosnetwork:txn May 15, 2023
@zhangsoledad zhangsoledad deleted the zhangsoledad/811 branch May 15, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants