forked from rust-rocksdb/rust-rocksdb
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rust-toolchain
to 1.67.1
#48
Merged
zhangsoledad
merged 4 commits into
nervosnetwork:txn
from
eval-exec:exec/upgrade-toolchain
May 23, 2023
Merged
Upgrade rust-toolchain
to 1.67.1
#48
zhangsoledad
merged 4 commits into
nervosnetwork:txn
from
eval-exec:exec/upgrade-toolchain
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eval EXEC <execvy@gmail.com>
eval-exec
commented
May 17, 2023
@@ -129,7 +129,7 @@ impl Drop for EnvWrapper { | |||
|
|||
impl Env { | |||
/// Returns default env | |||
pub fn default() -> Result<Self, Error> { | |||
pub fn default_env() -> Result<Self, Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rename Env::default()
to Env::default_env()
, because:
error: method `default` can be confused for the standard trait method `std::default::Default::default`
--> src/db_options.rs:132:5
|
132 | / pub fn default() -> Result<Self, Error> {
133 | | let env = unsafe { ffi::rocksdb_create_default_env() };
134 | | if env.is_null() {
135 | | Err(Error::new("Could not create mem env".to_owned()))
... |
138 | | }
139 | | }
| |_____^
|
= help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
= note: `-D clippy::should-implement-trait` implied by `-D warnings`
zhangsoledad
approved these changes
May 17, 2023
I forget to update |
doitian
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-toolchain
to1.67.1
cargo clippy
warnings.Env::default()
toEnv::default_env()
because https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_traitRequest for review. @zhangsoledad
Note:
libc::size_t
is a type alias ofusize
:https://github.com/rust-lang/libc/blob/586541b97e047cfec540fad752bc1eaca4acac36/src/unix/mod.rs#L19