feat: enable tcp base protocol listen on same port #382
+613
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
enable-tcp-base-protocol-listen-on-same-port
branch
from
cc989a7
to
6721eb8
Compare
eval-exec
reviewed
Nov 27, 2024
eval-exec
reviewed
Nov 27, 2024
eval-exec
reviewed
Nov 27, 2024
eval-exec
reviewed
Nov 27, 2024
driftluo
force-pushed
the
enable-tcp-base-protocol-listen-on-same-port
branch
from
6721eb8
to
25607f8
Compare
eval-exec
approved these changes
Nov 27, 2024
eval-exec
reviewed
Nov 27, 2024
| @@ -93,24 +95,36 @@ pub fn find_type(addr: &Multiaddr) -> TransportType { | |||
| .unwrap_or(TransportType::Tcp) | |||
| } | |||
|
|
|||
| pub(crate) fn parse_tls_domain_name(addr: &Multiaddr) -> Option<String> { | |||
| let mut iter = addr.iter(); | |||
There was a problem hiding this comment.
I think mut is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, TCP/WS/TLS could not be listened on the same port. After this PR, these protocols can be listened on the same port.