Adding light travel time code #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The radvel package doesn't have h5py in their installation requirements, but they do require it.
Note: this function requires that the stellar radius be provided in order to convert from relative units to physical units. At present, juliet seems not to require that this be added
|
Fantastic, thanks so much Taylor! Merging, and will add the option to incorporate the stellar radius, which I saw is passed to the function via N. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this function requires that the stellar radius be provided in order to convert from relative units to physical units. At present, juliet seems not to require that this be added.
I also tried to adjust my docstring format for the
correct_light_travel_timefunction, but I didn't bother for the larger KeplerOrbit.py file.