Fix mail transporter verification #1153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of json transporters, or any transporter which does not implement the
verify
function, the Mailer class inside nodemailer overwrites it with a generic non-async function, which just returnsfalse
. This leads to the following error:By wrapping the call to
transporter.verify()
insidePromise.resolve
we can safely proceed with the existing flow.See nodemailer source here: https://github.com/nodemailer/nodemailer/blob/fa63b52d8a03da49a60c00b6c073a0d77aeababb/lib/mailer/index.js#L95-L115