Fixed Handlebars/EJS template caching #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a hierarchical structure for the template folder, in which some files have the same name, only the template that gets rendered first will be used. Any subsequent calls will use the first template instead of the one actually passed, due to the precompiling step using only the file name as the key to the lookup object. This commit changes the key to the full relative path to fix this issue.
When using a hierarchical structure for the template folder, in which some files have the same name, only the template that gets rendered first will be used. Any subsequent calls will use the first template instead of the one actually passed, due to the precompiling step using only the file name as the key to the lookup object. This commit changes the key to the full relative path to fix this issue.
|
Hi, |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When organizing templates in subfolders, files with the same name are not rendered correctly. This is because Handlebars and EJS adapters precompile the templates and put them into a lookup object. However, as only the template name is used as the key, files from different subfolders cannot be distinguished. E.g.:
Using
en/myTemplaterenders the correct English file, any follow up calls use the cached English file as well, even if we passes/myTemplate. As a workaround we can use a prefix to make file names unique, as mentioned in #684, but imho it's better to have mailer support this natively.This pull request changes the keys of the lookup objects to the full relative paths, e.g.
en/myTemplateinstead of onlymyTemplateto fix the issue.