-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle OpenMP linker flags #3051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. It looks good to me. I would just like to make one suggestion for improvement. In order to report on the OpenMP libraries used, we could add the following to ConfigureSummary.cmake
, after line 102:
message( " Libraries : ${OpenMP_CXX_LIBRARIES}" )
@gtrensch Thanks for the suggestion, fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Until now, we placed
OpenMP_CXX_FLAGS
in theMODULE_LINK_LIBS
for nest. This is not quite correct and meant thatlibomp
was missing from the list of libraries returned bynest-config --libs
, which in turn caused trouble for building external models with OpenMP, at least on macOS. This PR fixes this.