-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move registration of ConnBuilders, Backends, growth curves from nestmodule to respective managers, allowing unloading #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckends form external modules.
…reloading ConnBuilders form external modules.
…s up before device models are registered
heplesser
added
T: Enhancement
New functionality, model or documentation
S: High
Should be handled next
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
labels
Mar 12, 2024
@pnbabu @terhorstd #3149 is now ready for review as #3103 has been merged. Two comments:
|
pnbabu
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
terhorstd
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: High
Should be handled next
T: Enhancement
New functionality, model or documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #3103 and should be merged only after it (the set of changes in this one then becomes much smaller). It moves the registration of ConnBuilders, Recording/StimulationBackends and SP growth curves from
nestmodule::init()
to theinitialize()
methods of Connection, IO and SP Manger respectively, with corresponding clean-up in thefinalize()
methods. The actual changes are small, sincenestmodule::init()
in the past calledregister_*
methods in the respective managers.Thus, these elements will be unloaded on
ResetKernel()
and such elements provided by extension modules can be reloaded. Therefore, if at all possible, this should still make it into 3.7 together with #3103.Parameters and Masks should be re-organizedi in the same way, but they are fully managed by nestmodule and seemingly with a rather complicated approach (parameters are also available as SLI objects), so their transition to the new scheme is more work and needs to wait.