Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(geopandas io): fixes dependency on gpd installation #93

Merged
merged 1 commit into from
Jan 9, 2024
Merged

refactor(geopandas io): fixes dependency on gpd installation #93

merged 1 commit into from
Jan 9, 2024

Conversation

sqr00t
Copy link
Contributor

@sqr00t sqr00t commented Jan 4, 2024 •
edited
Loading

Refactor GeoPandas Utils

This PR closes the issues: #91

Description

This PR moves geopandas IO to it's own script, gis_interface.py. This script attempts import of geopandas dependencies, catching import errors as a deactivated feature flag. S3.py will now import this flag and conditionally import utils if import succeeds when [gis] feature or geopandas is installed.

Checklist:

  • I have followed Contributor Guidelines
  • I have updated the documentation to include any new functionality I have added or modified
  • I have written unit tests for any new functionality I have added
  • I have ran and passed all tests locally with >> pytest
  • I have checked that all tests ran successfully on the Github after I pushed

@sqr00t sqr00t requested a review from j-gillam January 4, 2024 02:08
@sqr00t sqr00t linked an issue Jan 4, 2024 that may be closed by this pull request
[Bug]: Geopandas needed for loading_saving S3 #91
Closed
j-gillam
j-gillam approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@j-gillam j-gillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sqr00t sqr00t merged commit cbe4a6c into dev Jan 9, 2024
3 checks passed
@sqr00t sqr00t deleted the 91_fix_gpd_import branch January 9, 2024 16:12
@sqr00t sqr00t mentioned this pull request Jan 9, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-gillam j-gillam j-gillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Geopandas needed for loading_saving S3
2 participants
@sqr00t @j-gillam