-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typed-cqrs): use symbol field to store type of query #3
Conversation
Is this unmaintained? |
package.json
Outdated
@@ -45,6 +45,7 @@ | |||
"url": "https://github.com/nestjs-architects/typed-cqrs/issues" | |||
}, | |||
"devDependencies": { | |||
"@nestjs-architects/typed-cqrs": "file:./", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, I can remove it from the PR if you want, but this removes the need to call npm link
in order for the examples to typecheck correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed and rebased
Cool! amazing contribution @Papooch |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
npm run build
without needing to use link.What is the current behavior?
The same as before, only now there's no random property visible on the query.
Issue Number: N/A
Does this PR introduce a breaking change?
Fixes #4