Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exposed multipart-body axios functions #1031

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kpervin
Copy link
Contributor

@kpervin kpervin commented Feb 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1030

What is the new behavior?

Exposed Axios Multipart Bodies methods in HttpService.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@micalevisk
Copy link
Member

micalevisk commented Feb 23, 2024

these new methods weren't introduced in axios v1.0.0, right? I think we need to bump the peer dependency on axios to force the newer version... but I'm not sure

axios/package.json

Lines 47 to 50 in 8e0ecc4

"peerDependencies": {
"@nestjs/common": "^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0",
"axios": "^1.3.1",
"rxjs": "^6.0.0 || ^7.0.0"

@kpervin
Copy link
Contributor Author

kpervin commented Feb 23, 2024

I will check. I believe the version I have is 1.6.7. I can see when they introduced these features and make that the minimum peerDependency

@kpervin
Copy link
Contributor Author

kpervin commented Feb 26, 2024

@micalevisk Seems it was added into v0.27.0 in PR #4448

@kamilmysliwiec kamilmysliwiec merged commit b232d92 into nestjs:master Oct 21, 2024
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants