Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: log errors from event handlers #728

Closed
wants to merge 1 commit into from

Conversation

Sikora00
Copy link
Contributor

Add log when event handler faced an error
before the app crash

Refs #409

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When an event handler faces an uncaught error the app is crashing without any information of the source of the problem.

Issue Number: #409

What is the new behavior?

We get information that the crash is caused by a specific event handler.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Add log when event handler faced an error
before the app crash

Refs nestjs#409
@Sikora00 Sikora00 closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant