Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event-bus): log subscription errors #927

Merged
merged 4 commits into from
May 5, 2022

Conversation

Sikora00
Copy link
Contributor

@Sikora00 Sikora00 commented Feb 20, 2022

Log errors produced by an event handler
and by a saga as they crash the app.

Refs #409

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 409

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Log errors produced by an event handler
and by a saga as they crash the app.

Refs 409
@Sikora00
Copy link
Contributor Author

It's a revert from the old one #740

@maurolucc
Copy link

When are you planning to merge this fix? We're eager to enjoy it.

src/event-bus.ts Outdated Show resolved Hide resolved
src/event-bus.ts Outdated Show resolved Hide resolved
src/event-bus.ts Outdated Show resolved Hide resolved
@kamilmysliwiec kamilmysliwiec merged commit 95ae336 into nestjs:master May 5, 2022
@Sikora00 Sikora00 deleted the feat/409-logging branch May 5, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants