refactor: always generate schema regardless of http adapter existence

nestjs · Oct 5, 2022 · 1fd5e21 · 1fd5e21
1 parent f808ce3
commit 1fd5e21
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/graphql/lib/drivers/abstract-graphql.driver.ts b/packages/graphql/lib/drivers/abstract-graphql.driver.ts
@@ -13,7 +13,7 @@ export abstract class AbstractGraphQLDriver<
   protected readonly httpAdapterHost: HttpAdapterHost;
 
   @Inject()
-  protected readonly applicationConfig: ApplicationConfig;
+  protected readonly applicationConfig?: ApplicationConfig;
 
   @Inject()
   protected readonly graphQlFactory: GraphQLFactory;
@@ -54,7 +54,7 @@ export abstract class AbstractGraphQLDriver<
   }
 
   protected getNormalizedPath(options: TOptions): string {
-    const prefix = this.applicationConfig.getGlobalPrefix();
+    const prefix = this.applicationConfig?.getGlobalPrefix() ?? '';
     const useGlobalPrefix = prefix && options.useGlobalPrefix;
     const gqlOptionsPath = normalizeRoutePath(options.path);
     return useGlobalPrefix

diff --git a/packages/graphql/lib/graphql.module.ts b/packages/graphql/lib/graphql.module.ts
@@ -146,11 +146,6 @@ export class GraphQLModule<
   }
 
   async onModuleInit() {
-    const httpAdapter = this.httpAdapterHost?.httpAdapter;
-    if (!httpAdapter) {
-      return;
-    }
-
     const options = await this._graphQlAdapter.mergeDefaultOptions(
       this.options,
     );
@@ -172,6 +167,11 @@ export class GraphQLModule<
       typeDefs: undefined,
     };
 
+    const httpAdapter = this.httpAdapterHost?.httpAdapter;
+    if (!httpAdapter) {
+      return;
+    }
+
     await this._graphQlAdapter.start(completeOptions);
 
     if (options.path) {