fix(): preserve order of properties in schema definition #1277

nestjs · Mar 11, 2022 · 8b31897 · 8b31897
1 parent e96fec3
commit 8b31897
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/storages/type-metadata.storage.ts b/lib/storages/type-metadata.storage.ts
@@ -8,7 +8,7 @@ export class TypeMetadataStorageHost {
   private properties = new Array<PropertyMetadata>();
 
   addPropertyMetadata(metadata: PropertyMetadata) {
-    this.properties.push(metadata);
+    this.properties.unshift(metadata);
   }
 
   addSchemaMetadata(metadata: SchemaMetadata) {

diff --git a/tests/e2e/schema-definitions.factory.spec.ts b/tests/e2e/schema-definitions.factory.spec.ts
@@ -84,6 +84,26 @@ class ExampleClass {
 describe('DefinitionsFactory', () => {
   it('should generate a valid schema definition', () => {
     const definition = DefinitionsFactory.createForClass(ExampleClass);
+
+    expect(Object.keys(definition)).toEqual([
+      'objectId',
+      'name',
+      'buffer',
+      'decimal',
+      'mixed',
+      'expiresAt',
+      'map',
+      'isEnabled',
+      'number',
+      'ref',
+      'child',
+      'child2',
+      'nodes',
+      'customArray',
+      'customObject',
+      'any',
+      'array',
+    ]);
     expect(definition).toEqual({
       objectId: {
         type: mongoose.Schema.Types.ObjectId,