feat: Add connection error handle #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lib/mongoose-core.module.ts
Outdated
Comment on lines
71
to
72
| mongooseConnectionError(error); | ||
| throw error; |
There was a problem hiding this comment.
Suggested change
| mongooseConnectionError(error); | |
| throw error; | |
| throw mongooseConnectionError(error); |
what about this approach instead (this in combination with https://github.com/nestjs/mongoose/pull/1550/files#r1003070783)?
There was a problem hiding this comment.
That's a very nice suggestion
Return MongooseError Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com>
| @@ -9,6 +9,7 @@ export interface MongooseModuleOptions | |||
| retryDelay?: number; | |||
| connectionName?: string; | |||
| connectionFactory?: (connection: any, name: string) => any; | |||
| connectionError?: (error: MongooseError) => MongooseError; | |||
There was a problem hiding this comment.
Suggested change
| connectionError?: (error: MongooseError) => MongooseError; | |
| connectionErrorFactory?: (error: MongooseError) => MongooseError; |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1247
What is the new behavior?
Described here: #1247
Does this PR introduce a breaking change?
Other information