fix: allow defining path type
option as an array
#1607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When trying to declare an array schema path with additional options, an error is thrown due to invalid schema configuration.
throws
Invalid schema configuration: 'Profile' is not a valid type within the array 'profiles'.
The only way to fix it is by using
@Prop({ type: [SchemaFactory.createForClass(Profile)], required: true })
, or using@Prop([Profile])
while loosing the ability to pass additional optionsIssue Number: #839
What is the new behavior?
The PR allows defining
type
option as an array of subdocuments so that@Prop({ type: [Profile], required: true })
would work as expected.Does this PR introduce a breaking change?
Other information