Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide retry message when no retries will be attempted #2190

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

blended-bram
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

NestJS logs that a retry will be attempted when configuring the mongoose module with retryAttempts: 0:

[Nest] 20128  - 07/11/2024, 2:25:55 PM   ERROR [MongooseModule] Unable to connect to the database. Retrying (1)...
[Nest] 20128  - 07/11/2024, 2:25:55 PM   ERROR [ExceptionHandler] Authentication failed.

Issue Number: N/A

What is the new behavior?

Mongoose module does not indicate that a retry will be attempted:

[Nest] 20128  - 07/11/2024, 2:25:55 PM   ERROR [MongooseModule] Unable to connect to the database.
[Nest] 20128  - 07/11/2024, 2:25:55 PM   ERROR [ExceptionHandler] Authentication failed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit a6285c2 into nestjs:master Oct 21, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants