fix(plugin): use unknown to fix ts incompatibility issues

nestjs · Jul 5, 2023 · 882722d · 882722d
1 parent 3b60994
commit 882722d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/lib/compiler/interfaces/readonly-visitor.interface.ts b/lib/compiler/interfaces/readonly-visitor.interface.ts
@@ -9,9 +9,11 @@ export type DeepPluginMeta =
 export interface ReadonlyVisitor {
   key: string;
   typeImports: Record<string, string>;
-  visit<Program = any, SourceFile = any>(
-    program: Program,
-    sf: SourceFile,
-  ): void;
-  collect<MetaTuple = any>(): Record<string, Array<MetaTuple>>;
+
+  // Using unknown here because of the potential
+  // incompatibility between a locally installed TypeScript version
+  // and the one used by the CLI.
+
+  visit(program: unknown, sf: unknown): unknown;
+  collect(): Record<string, Array<unknown>>;
 }
diff --git a/lib/compiler/plugins/plugin-metadata-generator.ts b/lib/compiler/plugins/plugin-metadata-generator.ts
@@ -125,9 +125,7 @@ export class PluginMetadataGenerator {
   ) {
     for (const sourceFile of programRef.getSourceFiles()) {
       if (!sourceFile.isDeclarationFile) {
-        visitors.forEach((visitor) =>
-          visitor.visit<ts.Program, ts.SourceFile>(programRef, sourceFile),
-        );
+        visitors.forEach((visitor) => visitor.visit(programRef, sourceFile));
       }
     }
 
@@ -138,7 +136,10 @@ export class PluginMetadataGenerator {
     > = {};
 
     visitors.forEach((visitor) => {
-      collectedMetadata[visitor.key] = visitor.collect();
+      collectedMetadata[visitor.key] = visitor.collect() as Record<
+        string,
+        Array<[ts.CallExpression, DeepPluginMeta]>
+      >;
       typeImports = {
         ...typeImports,
         ...visitor.typeImports,